feat: Raids, shapes, raycasts and blockstates, oh my!#205
Open
ENDERZOMBI102 wants to merge 1 commit intoOrnitheMC:gen2from
Open
feat: Raids, shapes, raycasts and blockstates, oh my!#205ENDERZOMBI102 wants to merge 1 commit intoOrnitheMC:gen2from
ENDERZOMBI102 wants to merge 1 commit intoOrnitheMC:gen2from
Conversation
Member
SpaceWalkerRS
left a comment
SpaceWalkerRS
left a comment
There was a problem hiding this comment.
looking good, thanks for the work!
| p 5 p_5 | ||
| p 6 p_6 | ||
| c net/minecraft/unmapped/C_27154081 net/minecraft/util/profiler/Profiler | ||
| c net/minecraft/unmapped/C_27154081 net/minecraft/util/profiler/ProfilerSystem |
Member
There was a problem hiding this comment.
Not sure if this change should go this far back.
Contributor
Author
There was a problem hiding this comment.
how do i fix it?
Member
There was a problem hiding this comment.
e.g. if you want to change it back only in 1.13.2 and earlier, then make the change in 1.13.2, and save using the saveMappingsUp task
| p 2 p_2 | ||
| p 3 p_3 | ||
| m ()Lnet/minecraft/unmapped/C_99937716; m_64651906 m_64651906 | ||
| m ()Lnet/minecraft/unmapped/C_99937716; m_64651906 getPointOfInteresttype |
| m (Ljava/lang/Object;)Lnet/minecraft/unmapped/C_22168528; m_55287479 getKey | ||
| p 1 value | ||
| m (Lnet/minecraft/unmapped/C_22168528;)Ljava/lang/Object; m_99220628 getOrDefault | ||
| m (Lnet/minecraft/unmapped/C_22168528;)Ljava/lang/Object; m_99220628 getOrNull |
Member
There was a problem hiding this comment.
this change may also not apply this far back?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mapped on 1.14.4:
Currently fitting at ~71% completion.